-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Music: fix crash when a file cannot be opened by vgmstream #273
Music: fix crash when a file cannot be opened by vgmstream #273
Conversation
Also I think I forgot to delete allocated objects:
I don't know how to handle this yet. I think I can store this "music" object to a private attribute, and delete it when the music is definitely stopped. Like SFX... about that for SFX we're not forced to allocate to the heap with the "new", we can just store a plain SoLoud::VGMStream |
Great point actually. I never thought about that but if you see a way to optimize the entire pattern for both audio sources, that would be fantastic. Let me know if you need any help on this! And thank you for the PR. Looking forward to it. |
Hey @myst6re any update on this one? I'd like to get this merged before 1.10 stable release. Let me know if I can be of any help :) |
Hello @julianxhokaxhiu the crash is fixed, but not the potential memory leak. I don't have time to push a fix this week, so you can merge this and if you want create a new issue for the memory leak |
No worries, I can wait for it then :) Was just to understand if this was stuck somewhere or waiting for another patch. Thanks, let me know when it's ready then! |
3860e11
to
5865416
Compare
5865416
to
704b139
Compare
Done |
Thank you! |
To reproduce: read a psf file with the psf plugin unloaded (if you don't have configured a hebios, it is unloaded for example).