Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Voice: Add voice support for display action/info #331

Merged

Conversation

tangtang95
Copy link
Contributor

  • Add voice support for display info about steal, mug, sense, ...
  • Disable keeping display text until voice end for display info about steal, mug, and etc
  • Add voice support for display action such as magic, limit breaks, ...
  • Implement random choice of character playing voice during display actions

- Add voice support for display info about steal, mug, sense, ...
- Disable keeping display text until voice end for display info about steal, mug, and etc
- Add voice support for display action such as magic, limit breaks, ...
- Implement random choice of character playing voice during display actions
@julianxhokaxhiu julianxhokaxhiu self-requested a review December 19, 2021 17:26
@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Dec 19, 2021
@julianxhokaxhiu julianxhokaxhiu added this to the 1.11 milestone Dec 19, 2021
Copy link
Owner

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Amazing, this is going to be a killer feature. Well done :)

@julianxhokaxhiu julianxhokaxhiu merged commit c4eb9e9 into julianxhokaxhiu:master Dec 19, 2021
@julianxhokaxhiu
Copy link
Owner

Thank you!

@tangtang95 tangtang95 deleted the feature/battle_voice branch June 23, 2022 15:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants