Implemented analogue camera controls in battle mode #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
sithlord48
reviewed
Jan 10, 2022
| @@ -248,20 +286,24 @@ struct ff7_gamepad_status* ff7_update_gamepad_status() | |||
| ff7_externals.gamepad_status->button5 = gamepad.IsPressed(XINPUT_GAMEPAD_LEFT_SHOULDER); // L1 | |||
| ff7_externals.gamepad_status->button6 = gamepad.IsPressed(XINPUT_GAMEPAD_RIGHT_SHOULDER); // R1 | |||
| ff7_externals.gamepad_status->button7 = gamepad.leftTrigger > 0.85f; // L2 | |||
| ff7_externals.gamepad_status->button8 = gamepad.rightTrigger > 0.85f; // R2 | |||
|
|
|||
| // Remap R2 trigger to R3 so that we can use the trigger for zoom-in when analogue controls are enabled | |||
There was a problem hiding this comment.
Please do not change controls if a feature is active.
What happens if this is enabled and i want to remap w/ R2 / L2 do in battle ?
I suggest
Either use L3 / R3 for zoom
or
Hold R2 or L2 and use the right stick's up / down for zoom
|
Hi, I noticed the following about this feature: The speedhack is activated via controller with L3 + L2/R2 (Playstation). L2/R2 buttons are also used for zooming in fights. This means that you always zoom in during battle when you switch on the speedhack. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added analogue controls for the battle camera. You can rotate the camera with the controller right stick and zoom-in/ zoom-out with the analogue triggers. Controls are only enabled when no camera animation is being executed.