Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FF7: Allow external audio in movies #343

Merged
merged 1 commit into from
Jan 13, 2022
Merged

FF7: Allow external audio in movies #343

merged 1 commit into from
Jan 13, 2022

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Jan 12, 2022

No description provided.

@myst6re myst6re force-pushed the feature/ff7-movie-ambient branch from 157d5be to 6198e19 Compare January 12, 2022 21:31
@myst6re myst6re marked this pull request as ready for review January 12, 2022 21:54
@myst6re myst6re force-pushed the feature/ff7-movie-ambient branch 2 times, most recently from 69f8b95 to 31f0642 Compare January 12, 2022 23:01
@myst6re
Copy link
Contributor Author

myst6re commented Jan 12, 2022

Rady for review

@julianxhokaxhiu julianxhokaxhiu self-requested a review January 13, 2022 00:35
@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Jan 13, 2022
@julianxhokaxhiu julianxhokaxhiu added this to the 1.11 milestone Jan 13, 2022
julianxhokaxhiu
julianxhokaxhiu approved these changes Jan 13, 2022
View reviewed changes
Copy link
Owner

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myst6re myst6re force-pushed the feature/ff7-movie-ambient branch from 31f0642 to 19dc951 Compare January 13, 2022 14:10
@julianxhokaxhiu julianxhokaxhiu changed the title FF7: Allow external ambient in movies FF7: Allow external audio in movies Jan 13, 2022
@myst6re myst6re force-pushed the feature/ff7-movie-ambient branch from 19dc951 to 75e3c6a Compare January 13, 2022 17:09
@julianxhokaxhiu julianxhokaxhiu merged commit 4a7d83d into julianxhokaxhiu:master Jan 13, 2022
@julianxhokaxhiu
Copy link
Owner

Thank you!

@myst6re myst6re deleted the feature/ff7-movie-ambient branch March 5, 2022 10:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@myst6re myst6re

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.
2 participants
@myst6re @julianxhokaxhiu