60FPS: Fix Climhazzard random crash on poisoned enemy #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianxhokaxhiu
previously approved these changes
Dec 29, 2022
|
Can you please update also the Changelog? |
tangtang95
force-pushed
the
bugfix/fix-climhazzard-crash-60fps
branch
from
6874290 to
15d003b
Compare
julianxhokaxhiu
approved these changes
Dec 30, 2022
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With 60 FPS mod, when using Climhazzard against enemy with status (e.g. poison), can cause a crash. This crash does not happen always, but somehow "randomly". I do not know the real cause, but I just disabled any decorator wrapper on the battle effect function that cause the crash. After testing it more than 10 times, I didn't get any crash.
Motivation
A user reported it.
ACKs