Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FF8: Increase max texture size to 16384 for external textures + Minor fixes #601

Merged

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Sep 13, 2023

Summary

  • Non-us version does not use similar addresses in Worldmap.
  • When an external texture contains an almost opaque alpha, like 254, the pixel is displayed black, force an opaque color to show the real color of the pixel instead
  • texl textures (high res worldmap textures) can only be upscaled to 1024x1024, because source height is incorrect. But it should be incorrect as it replaces low res worldmap textures. So I decided to increase MAX_SCALE a lot. Now it is possible to upscale texl to 16384 (which is the max texture size on my machine).

Motivation

Crash => no crash

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

…ore alpha from external texture most of the time. Increase max texture scale by a lot.
@myst6re myst6re force-pushed the fix/ff8-wm-voice-non-us2 branch from d7b13e4 to 629776f Compare September 13, 2023 22:31
@myst6re myst6re marked this pull request as ready for review September 13, 2023 22:38
@julianxhokaxhiu julianxhokaxhiu changed the title FF8 fix worldmap voice again on non-us versions FF8: Increase max texture size to 16384 for external textures + Minor fixes Sep 14, 2023
@julianxhokaxhiu julianxhokaxhiu self-requested a review September 14, 2023 09:26
@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working enhancement New feature or request labels Sep 14, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Sep 14, 2023
@julianxhokaxhiu
Copy link
Owner

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@julianxhokaxhiu julianxhokaxhiu merged commit 5c7da23 into julianxhokaxhiu:master Sep 14, 2023
@julianxhokaxhiu
Copy link
Owner

Thank you!

myst6re added a commit to myst6re/FFNx that referenced this pull request Sep 14, 2023
julianxhokaxhiu pushed a commit that referenced this pull request Sep 14, 2023
@myst6re myst6re deleted the fix/ff8-wm-voice-non-us2 branch November 3, 2023 09:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants