Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FF7: Fixed menu not working when using the buggy #657

Merged

Conversation

CosmosXIII
Copy link
Contributor

@CosmosXIII CosmosXIII commented Feb 18, 2024

Summary

Fixed menu not working when using the buggy and external worldmap. For some reason the world_is_player_model_bitmask function does not work so instead I made it check the model id values manually.

Motivation

To return the original behavior where the player can use the menu while using the buggy.

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@CosmosXIII CosmosXIII changed the title FF7: Fixed menu not working when using external worldmap mesh FF7: Fixed menu not working when using the buggy and external worldmap mesh Feb 18, 2024
@julianxhokaxhiu julianxhokaxhiu self-requested a review February 18, 2024 20:09
@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Feb 18, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.18.1 milestone Feb 18, 2024
@julianxhokaxhiu julianxhokaxhiu changed the title FF7: Fixed menu not working when using the buggy and external worldmap mesh FF7: Fixed menu not working when using the buggy Feb 18, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit bab18f1 into julianxhokaxhiu:master Feb 18, 2024
@julianxhokaxhiu
Copy link
Owner

Thank you :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants