Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FF8: Bring back shadows and tinted window #750

Merged

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Nov 12, 2024

Summary

Fixes #693 and more

Bring back shadows and tinted window
2024-11-11 22_25_03-Final Fantasy VIII _ FPS_ 30,0
Elevator window is darker
2024-11-13 00_01_53-Final Fantasy VIII _ FPS_ 15,0
Shadows are back

Battle transition + shadows
https://github.com/user-attachments/assets/674a7e17-cfd7-48ae-b84d-d32bb228cd5a

Field transition
https://github.com/user-attachments/assets/f26643be-1462-439a-bd11-076ec4b18471

Motivation

Substractive blending is enabled only if the graphic driver is software and use paletted textures.

Regression

Unfortunately Battle transition (from worldmap at least) suffer from this change

ACKs

  • I have updated the Changelog.md file
  • N/A I did test my code on FF7
  • I did test my code on FF8

@myst6re myst6re force-pushed the fix/693-substractive-blending branch 5 times, most recently from b93b180 to f8494bf Compare November 16, 2024 17:31
@myst6re myst6re force-pushed the fix/693-substractive-blending branch from f8494bf to 9eabb75 Compare November 16, 2024 17:32
@myst6re myst6re marked this pull request as ready for review November 16, 2024 17:34
@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working enhancement New feature or request labels Nov 16, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.21.0 milestone Nov 16, 2024
@julianxhokaxhiu julianxhokaxhiu changed the title FF8: Bring back shadows and tinted window #693 FF8: Bring back shadows and tinted window Nov 16, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit e814c15 into julianxhokaxhiu:master Nov 16, 2024
1 check passed
@julianxhokaxhiu
Copy link
Owner

Spectacular PR, well done :) Thank you!

@myst6re myst6re deleted the fix/693-substractive-blending branch November 17, 2024 14:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ FF8 ] Transparency appears really dark when using custom background textures
2 participants