Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fatal error on php5.4 with function-calls in empty-call #256

Closed
idittmar opened this issue Apr 14, 2021 · 0 comments · Fixed by #267
Closed

Fatal error on php5.4 with function-calls in empty-call #256

idittmar opened this issue Apr 14, 2021 · 0 comments · Fixed by #267

Comments

@idittmar
Copy link
Contributor

idittmar commented Apr 14, 2021

Hi!

I got the following fatal error on our servers running on php 5.4.45:

Fatal error: Can't use method return value in write context in (...)/src/OpenIDConnectClient.php on line 664

Php crashing on that line by the following statement:
if (!empty($this->getCodeChallengeMethod()) ...

As this solution suggests, putting the result of inner getCodeChallengeMethod-call before empty-call into an extra variable might be a quickfix for that problem.

Same error should also be fixed at line 775

I already forked master, and commited the fix. But since i'm new to github, i'm a bit unsure how to transfer it back into your repo?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant