mention that exponential cone also works in docs #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do exponential cones work? (I haven't tried.) x-ref #228 (comment), #50 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 12 12
Lines 1157 1157
=======================================
Hits 994 994
Misses 163 163 ☔ View full report in Codecov by Sentry. |
matbesancon
reviewed
May 1, 2023
| @@ -4,7 +4,7 @@ | |||
| This package has two major backends, available via the `reverse_differentiate!` and `forward_differentiate!` methods, to differentiate models (quadratic or conic) with optimal solutions. | |||
|
|
|||
| !!! note | |||
| Currently supports *linear programs* (LP), *convex quadratic programs* (QP) and *convex conic programs* (SDP, SOCP constraints only). | |||
| Currently supports *linear programs* (LP), *convex quadratic programs* (QP) and *convex conic programs* (SDP, SOCP, exponential cone constraints only). | |||
There was a problem hiding this comment.
Suggested change
| Currently supports *linear programs* (LP), *convex quadratic programs* (QP) and *convex conic programs* (SDP, SOCP, exponential cone constraints only). | |
| Currently supports convex quadratic conic programs (convex quadratic objective, conic constraints). The cone needs to have `MathOptSetDistances.projection_gradient_on_set` and `MathOptSetDistances.projection_on_set` implemented. |
Even broader
|
@currymj thanks for the PR! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most of the docs just refer to "conic programs", the note at the front specifically says only second-order and semidefinite programming is supported. this adds a small mention that the exponential cone is also supported.