Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement MOI.Utilities.scalar_type for (Matrix|Sparse)VectorAffineFunction #264

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

odow
Copy link
Member

@odow odow commented Jan 6, 2025

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.40%. Comparing base (07478f8) to head (4b5759e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/utils.jl 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   85.38%   85.40%   +0.02%     
==========================================
  Files          12       12              
  Lines        1156     1158       +2     
==========================================
+ Hits          987      989       +2     
  Misses        169      169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit e722173 into master Jan 7, 2025
9 of 10 checks passed
@odow odow deleted the od/scalar_type branch January 7, 2025 00:30
andrewrosemberg pushed a commit to andrewrosemberg/DiffOpt.jl that referenced this pull request Feb 5, 2025
joaquimg added a commit that referenced this pull request Feb 21, 2025
* NonLinearProgram

* index by MOI index

* only cache gradient

* update API

* start reverse mode

* add overloads

* update MOI wrapper

* update code for DiffOpt API

* working code

* usage example

* add reverse diff

* update code

* update tests

* update tests

* add forward_differentiate! tests

* add reverse_differentiate! tests

* update docs

* format

* update API reference

* fix typos

* update reference

* update spdiagm

* Typo "acutal" to "actual" (#258)

Correcting typo "acutal" to "actual"

* Fix GitHub actions badge in README (#263)

* Implement MOI.Utilities.scalar_type for (Matrix|Sparse)VectorAffineFunction (#264)

* Use SlackBridgePrimalDualStart (#253)

* Use SlackBridgePrimalDualStart

* Update src/copy_dual.jl

* Remove test_broken

* Add supports

* Add comment

* Move to AbstractModel

* Integrate with POI to improve UX (#262)

* [WIP] Integrate with POI to improve UX

* add missing import

* temp change to proj toml

* format

* simplify method setting to sue model constructor

* add possible fix to scalarize bridge error

* add pkg to project

* format

* improvements

* remove jump wrapper

* clean tests

* fix readme

* use intermediary API

* format

* Apply suggestions from code review

Co-authored-by: Benoît Legat <benoit.legat@gmail.com>

* add suggestion

* use Parameter set

* todo was fixed

* format

* update docs for newer Flux

* format

* kwargs

* remove diff model

* suggestions

* format

* fix examples

---------

Co-authored-by: Benoît Legat <benoit.legat@gmail.com>

* Add error for missing starting value (#269)

* update API

* expose kwargs

* restrict hessian type

* reverse wrong change

* update usage

* fix mad merge

* fix typo

* fix typo

* fix wrong index

* reverse index

* allow user to just set relevat sensitivities

* fix copy reverse sensitivity dual

* format

* update tests

* format

* update docs

* extend parameter @test_throws tests for NLP

* update comments

* update private api: _add_leq_geq

* fix typo

* continue fix typo check asserts

* expose factorization through as MOI.AbstractModelAttribute

* add tests factorization

* add comment

* rm rm kwargs

* use correct underscore signature for private funcs

* format

* change github actions to v3

* reverse checkout version

* add reference sipopt paper

* update factorization routine API

* format

* Update ci.yml

* improve coverage

* add test inertia correction

* add test ReverseConstraintDual

* format

* rm useless checks

* add test get ReverseConstraintDual

* format

* rm unecessary funcs

* rm kwargs

* format

* rename factorization attributte

* add supports

* Apply suggestions from code review

---------

Co-authored-by: mzagorowska <7868389+mzagorowska@users.noreply.github.com>
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
Co-authored-by: Benoît Legat <benoit.legat@gmail.com>
Co-authored-by: Joaquim <joaquimdgarcia@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant