Add JuMP-like API #281
Open
Add JuMP-like API #281
+286
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 89.08% 89.10% +0.02%
==========================================
Files 15 16 +1
Lines 1969 1992 +23
==========================================
+ Hits 1754 1775 +21
- Misses 215 217 +2 ☔ View full report in Codecov by Sentry. |
blegat
reviewed
Feb 24, 2025
| ) | ||
| inner = diff_optimizer( | ||
| optimizer_constructor; | ||
| with_parametric_opt_interface = false, |
There was a problem hiding this comment.
Add comment on why this is false
There was a problem hiding this comment.
Yup, I might re rewrite some of the internals to try to ger rid of this
blegat
reviewed
Feb 24, 2025
| (DiffOpt.quadratic_diff_model, SCS.Optimizer), | ||
| (DiffOpt.quadratic_diff_model, Ipopt.Optimizer), | ||
| # (DiffOpt.conic_diff_model, HiGHS.Optimizer), | ||
| # (DiffOpt.conic_diff_model, SCS.Optimizer), # conicmodel has a issue with sign |
There was a problem hiding this comment.
We need at least one of the three to be enabled otherwise it's not tested
There was a problem hiding this comment.
Yup,
But there is a bug.
Conic returns wrong # some cases.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #271