Skip to content

Prepare integration with DiffOpt #161

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 20 commits into from
Jan 7, 2025
Merged

Prepare integration with DiffOpt #161

merged 20 commits into from
Jan 7, 2025

Conversation

joaquimg
Copy link
Member

replaces #143

This will be associated with a PR in DiffOpt.

The main goal is to keep POI as simple and low-weight as possible.
This way, the responsibility for understanding differentiation falls on DiffOpt and its maintainers.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.39%. Comparing base (18401ef) to head (bb7ff58).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/MOI_wrapper.jl 94.59% 2 Missing ⚠️
src/parametric_functions.jl 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   95.15%   95.39%   +0.24%     
==========================================
  Files           5        5              
  Lines        1031     1085      +54     
==========================================
+ Hits          981     1035      +54     
  Misses         50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquimg joaquimg changed the title [WIP] prepare integration with DiffOpt Prepare integration with DiffOpt Dec 28, 2024
@joaquimg joaquimg merged commit 455541d into master Jan 7, 2025
8 checks passed
@joaquimg joaquimg deleted the jg/diff2 branch January 7, 2025 16:42
@joaquimg joaquimg mentioned this pull request Jan 7, 2025
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant