Skip to content

Use correct interfaces to build host #17

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
May 18, 2021
Merged

Conversation

junalmeida
Copy link
Owner

Added documentation and syntax changes on top of https://github.com/waynebrantley/autofac-azurefunctions PR #16

Possible breaking change: Use correct interfaces to build up host IConfiguration. Please read sample Startup.cs to see how to use UseAppSettings.

Possible breaking change: Use correct AZURE_FUNCTIONS_ENVIRONMENT to determine your environment. It is Production by default on Azure servers, Development locally. See Azure/azure-functions-host#6239

@junalmeida
Copy link
Owner Author

@waynebrantley Could you please review? I made some minor change on the ConfigureLogger for backwards compatibility's sake. All other changes are related to documentation.

Copy link
Contributor

@waynebrantley waynebrantley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Nice work. Thanks!

@junalmeida junalmeida merged commit 7a08e12 into master May 18, 2021
@junalmeida junalmeida deleted the use-correct-interfaces branch May 18, 2021 19:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants