Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[zsh/completion] don't unescape FZF_DEFAULT_OPTS #4262

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[zsh/completion] don't unescape FZF_DEFAULT_OPTS #4262

merged 1 commit into from
Feb 20, 2025

Conversation

Lompik
Copy link
Contributor

@Lompik Lompik commented Feb 20, 2025

With zsh, binding ctrl-\ in FZF_DEFAULT_OPTS breaks fzf completion trigger (but fzf-history-widget ctrl-r works). Turns out __fzf_defaults unescapes the backslash. This PR intends to fix that.

to reproduce: use config below and trigger fzf completions with $FZF_COMPLETION_TRIGGER:

export FZF_DEFAULT_OPTS='--bind=ctrl-\\:toggle-track'

@junegunn junegunn merged commit 309b508 into junegunn:master Feb 20, 2025
5 checks passed
@junegunn
Copy link
Owner

Merged, thanks!

junegunn added a commit that referenced this pull request Feb 20, 2025
@junegunn
[zsh/key-bindings] don't unescape FZF_DEFAULT_OPTS (addendum: #4262)
dac8143
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lompik @junegunn