Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove equality and hashing methods from Record interface #18

Merged
merged 4 commits into from
Dec 18, 2022

Conversation

jungaretti
Copy link
Owner

Removes repetitive Equals and Hash methods from the dns.Record interface.

The deploy command is the only code that uses these methods. Instead, it should be responsible for diffing all Record implementations using their existing methods.

@jungaretti jungaretti marked this pull request as ready for review December 16, 2022 06:01
@jungaretti jungaretti changed the title Remove restrictive record methods Remove equality and hashing methods from Record interface Dec 16, 2022
@jungaretti jungaretti merged commit f3e6141 into main Dec 18, 2022
@jungaretti jungaretti deleted the remove-equals-hash branch November 26, 2023 00:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant