Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document that AnnotationSupport.isAnnotated() does not find repeatable annotations #4243

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

YongGoose
Copy link
Contributor

@YongGoose YongGoose commented Jan 12, 2025

Resolves: #4058

Overview

  • Update the Javadoc for both AnnotationSupport.isAnnotated() variants to reflect this.
  • Update the User Guide documentation for AnnotationSupport to reflect this, if applicable.
  • Update the Javadoc for AnnotatedElementContext.isAnnotated() to reflect this.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've requested a few minor changes.

YongGoose and others added 4 commits January 13, 2025 18:33
Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
…s/support/AnnotationSupport.java

Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
…s/support/AnnotationSupport.java

Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
@YongGoose
Copy link
Contributor Author

YongGoose commented Jan 13, 2025

@marcphilipp @sbrannen

Thank you for your comments!
They were incredibly helpful in making revisions👍🏻

@marcphilipp marcphilipp merged commit f07e3ff into junit-team:main Jan 16, 2025
15 checks passed
@marcphilipp
Copy link
Member

@YongGoose Thank you! 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that AnnotationSupport.isAnnotated() does not find repeatable annotations
3 participants