Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve value label generation for writestat and update documentation #23

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

junyuan-chen
Copy link
Owner

Value labels are generated for CategoricalArray and PooledArray by default when writing a table containing such array types.

@junyuan-chen junyuan-chen added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #23 (c040b99) into main (8c164f3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          10       10           
  Lines        1145     1158   +13     
=======================================
+ Hits         1144     1157   +13     
  Misses          1        1           
Impacted Files Coverage Δ
src/ReadStatTables.jl 100.00% <ø> (ø)
src/readstat.jl 99.20% <ø> (ø)
src/table.jl 100.00% <100.00%> (ø)
src/writer.jl 100.00% <100.00%> (ø)
src/writestat.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@junyuan-chen junyuan-chen merged commit 60a8a59 into main Jan 19, 2023
@junyuan-chen junyuan-chen deleted the pr/refpoolaslabel branch January 19, 2023 09:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant