Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix the wrong row offsets when using more than two threads #24

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

junyuan-chen
Copy link
Owner

An urgent bug caused by a typo has escaped the tests as it only affects the results when more than two threads are used.

The threshold used to set ntasks is modified to be more conservative.

@junyuan-chen junyuan-chen added the bug Something isn't working label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #24 (083475a) into main (9b59214) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          10       10           
  Lines        1158     1158           
=======================================
  Hits         1157     1157           
  Misses          1        1           
Impacted Files Coverage Δ
src/readstat.jl 99.20% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@junyuan-chen junyuan-chen merged commit 41bb62e into main Feb 3, 2023
@junyuan-chen junyuan-chen deleted the pr/row_offsets branch February 3, 2023 19:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant