📚 Allow multiple pages in typst export #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanc1
commented
Jan 11, 2024
Comment on lines
31
to
+32
| ExportFormats.tex, | ||
| ExportFormats.typst, |
There was a problem hiding this comment.
@fwkoch I am not actually sure we should add this, can you confirm?
rowanc1
commented
Jan 11, 2024
| @@ -261,12 +262,13 @@ export async function localArticleToTypstTemplated( | |||
| const includeFileBases = results.map((result, ind) => { | |||
| const base = `${name}-${content[ind]?.slug ?? ind}${ext}`; | |||
| const includeFile = path.format({ dir, ext, base }); | |||
| writeFileToFolder(includeFile, result.value); | |||
| const exports = renderTypstImports(false, collected); | |||
| writeFileToFolder(includeFile, `${versionString}\n\n${exports}\n\n${result.value}`); | |||
There was a problem hiding this comment.
Typst exports on different pages need to also have imports in each page.
fwkoch
approved these changes
Jan 11, 2024
| @@ -29,6 +29,7 @@ export async function resolvePageExports(session: ISession, file: string) { | |||
| ExportFormats.docx, | |||
| ExportFormats.pdf, | |||
| ExportFormats.tex, | |||
| ExportFormats.typst, | |||
| @@ -3,18 +3,18 @@ import type { TypstTemplateImports } from '../types.js'; | |||
| import { writeFileToFolder } from 'myst-cli-utils'; | |||
|
|
|||
| export function renderTypstImports( | |||
| output: string, | |||
| output: string | false, | |||
There was a problem hiding this comment.
Ah, this stops writing myst.typ multiple times for multi-page export. Shouldn't be false in other cases.
| writeFileToFolder(mystTypst, macros.join('\n\n')); | ||
| } | ||
| importStatements.push('#set math.equation(numbering: "(1)")'); |
There was a problem hiding this comment.
Was this moved to the template?
| @@ -261,12 +262,13 @@ export async function localArticleToTypstTemplated( | |||
| const includeFileBases = results.map((result, ind) => { | |||
| const base = `${name}-${content[ind]?.slug ?? ind}${ext}`; | |||
| const includeFile = path.format({ dir, ext, base }); | |||
| writeFileToFolder(includeFile, result.value); | |||
| const exports = renderTypstImports(false, collected); | |||
There was a problem hiding this comment.
Ugh, a bit tedious we have to add these here, but they get added to the main page during render... but makes sense.
There was a problem hiding this comment.
Yeah, I was a bit suprised.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for multi-page exports for typst