Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix missing url passing when using a custom authenticator #684

Merged

Conversation

gthomas-slack
Copy link
Contributor

@gthomas-slack gthomas-slack commented Nov 16, 2020

Description

Fixes a bug with passing the url from the configuration when using a Custom Authenticator. Fixes #683 - see this issue for more details.

Checklist

  • Wrote a description of my changes above
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • If adding a feature, there is an example notebook and/or documentation in the README.md file

Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I'll include this in a new patch release as soon as I can

@itamarst
Copy link
Contributor

Unit test would be nice too, @gthomas-slack.

Also, would you be interested in being given commit access? You'd have to agree to following the development process, and the code of conduct.

@VasuBhog
Copy link

Would this be patched into the 0.17.0 version or released with the next 0.18.0 release? What would be the timeframe for either option?

@devstein
Copy link
Collaborator

@VasuBhog It will be a new patch release 0.17.1. I'll release it in the next few hours

@devstein devstein merged commit f70ca90 into jupyter-incubator:master Nov 18, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] url is not passed from config.json file
4 participants