Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

block kwarg removed in jupyter-client 7 #367

Closed
tschaume opened this issue Aug 21, 2021 · 2 comments · Fixed by #368
Closed

block kwarg removed in jupyter-client 7 #367

tschaume opened this issue Aug 21, 2021 · 2 comments · Fixed by #368

Comments

@tschaume
Copy link
Contributor

This commit in jupyter-client 7 removes the block kwarg for get_msg used here
tschaume added a commit to materialsproject/MPContribs that referenced this issue Aug 21, 2021
@tschaume
pin jupyter-client < 7
c8130eb 
jupyter-server/kernel_gateway#367
kevin-bates referenced this issue in jupyter/jupyter_client Aug 21, 2021
@davidbrochart
Remove block parameter from get_msg()
f365a22
@kevin-bates
Copy link
Member

hi @tschaume. Did you want to provide a PR for this? I believe it's a matter of using the channel helper methods instead as referenced in the resolution for issue 2 here: jupyter/jupyter_client#640 (comment)

@tschaume tschaume mentioned this issue Aug 21, 2021
Merged
@tschaume
Copy link
Contributor Author

@kevin-bates Thanks for the pointer! I started PR #368

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use get_shell_msg helper method tschaume/kernel_gateway
2 participants
@tschaume @kevin-bates