Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

hide out_prompt_overlay in Output widget #1765

Closed
mheilman opened this issue Oct 20, 2017 · 7 comments · Fixed by #1766
Closed

hide out_prompt_overlay in Output widget #1765

mheilman opened this issue Oct 20, 2017 · 7 comments · Fixed by #1766
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@mheilman
Copy link
Contributor

The Output widget shows the overlay on the left side of the output area that lets people collapse an output cell in a notebook (see screenshot below). It doesn't seem like this is behavior that one would want when using an Output widget. Would it be possible to hide this overlay by default or make it optional?

screen shot 2017-10-20 at 12 49 13 pm

Would it make sense to add some CSS like .jupyter-widgets-output-area > .out_prompt_overlay {display: none}?

@jasongrout
Copy link
Member

jasongrout commented Oct 20, 2017

That prompt area should be hidden:

It's hidden for me, with the element having an explicit style "display: none". Can you check the javascript code to make sure that line above is saying prompt_area: false?

What version of the notebook are you using?

@jasongrout jasongrout added this to the Reference milestone Oct 20, 2017
@mheilman
Copy link
Contributor Author

It looks like that that line is in the version of the widgets nb extension I have (though I'm looking at webpacked JS here):

screen shot 2017-10-20 at 1 49 21 pm

This is with the current commit in master (3af1317) and notebook==5.1.0

@jasongrout
Copy link
Member

Huh, I just reproduced it. Looking into it...

@jasongrout
Copy link
Member

Looks like a bug in the notebook, introduced in jupyter/notebook#2681.

Proposed fix for the notebook at jupyter/notebook#2961

For us, I agree that we should add some stop-gap CSS to get rid of it.

@jasongrout
Copy link
Member

Would it make sense to add some CSS like .jupyter-widgets-output-area > .out_prompt_overlay {display: none}?

Do you want submit a PR adding this to https://github.com/jupyter-widgets/ipywidgets/blob/master/widgetsnbextension/src/widget_output.css with an explanatory note pointing to the notebook PR and this discussion?

@jasongrout jasongrout modified the milestones: Reference, 7.x Oct 20, 2017
@jasongrout
Copy link
Member

(then I'll release a quick widgetsnbextension 3.0.6 with just this fix)

jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Oct 20, 2017
This works around for the bug fixed in jupyter/notebook#2961

Thanks to @mheilman for noting the problem and suggesting a fix.

Fixes jupyter-widgets#1765
@jasongrout
Copy link
Member

Do you want submit a PR

I went ahead and made a PR for it so we can get a fix out before the weekend.

@jasongrout jasongrout modified the milestones: 7.x, 7.0.x Oct 27, 2017
@jasongrout jasongrout modified the milestones: 7.0.x, 7.0.4 Nov 17, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants