-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Defer loading of widget implementation to first usage #85
Open
bollwyvl
wants to merge
6
commits into
jupyter-widgets:master
Choose a base branch
from
bollwyvl:add-lazy-load
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I love it, and plan to do it to the widget libraries I maintain as well. I think you have a similar or open on bqplot, and I'd like to see that merged as well. |
Rebased onto the latest |
Probably referring to this PR? bqplot/bqplot#1192 |
fcollonval
reviewed
Mar 17, 2021
I like having named chunks for debuggability and_proof_, but yeah it's
probably just vanity window dressing.
|
ha, down to |
Huzzah ✔️ ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this!
This adds lazy-loading of the widget implementation, CSS, and dependencies to the Lab plugin. From a cold cache, this trades:
The trade gets a bit murkier with cache, but parsing a huge
main
is also not free, and I suspect this time goes up faster than linearly.Motivation
I've done this PR on a whole stack of projects, at this point... the arguments are usually for end users encountering fewer webpack issues (from reduced size/file count of
vendor~main
). I haven't had anybody revert the change, so seems reasonable to promote more broadly. For developers, it makes sourcemaps for the code in question and dependencies snappier, as it's no longer in the titanicmain
bundle. I have encountered no issues with deduplication.