Improve usability of jp_read_emitted_events fixture #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if a test using events attempts to read emitted events using the fixture
jp_read_emitted_events
where either no events were emitted or the handler wasn't registered correctly, aJSONDecodeError
will be produced, along with its stack trace:This pull request avoids the call to
json.loads()
when the event sink is empty and returnsNone
, leading to a more friendly and intuitive error situation:While looking into this change, I noticed that the default value for the
handlers
trait was set to[]
despite the help string stating thatNone
is the default, so I've gone ahead and changed the default toNone
.