Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use var instead of const to ensure js-test succeed #159

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

echarles
Copy link
Member

#156 has introduced a regression for the js-test, using const keyword in the javascript which does not seem to be supported by the tests.

This PR fixed this issue.

@echarles echarles changed the title Use var and not const to ensure js-test succeed Use var instead of const to ensure js-test succeed Oct 11, 2022
@echarles echarles changed the title Use var instead of const to ensure js-test succeed Use var instead of const to ensure js-test succeed Oct 11, 2022
@echarles echarles added the bug Something isn't working label Oct 11, 2022
Copy link
Collaborator

@ericsnekbytes ericsnekbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants