Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rebased: Make Cells Display Lazily When Diffing Unchanged Cells #733

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vidartf
Copy link
Collaborator

@vidartf vidartf commented Nov 10, 2023

This is a rebased version of #636 . It will still need work as commented on that PR:

  • Ensure icons style with lab theme.
  • Ensure new elements' colors work with different lab themes.
  • Ensure we didn't loose any functionality in the rebase

Motivation:
  During diffing Unchanged cells are displayed, which is not necessary.
  This is a performance issue when there are many unchanged cells.

Related Issues:
  - jupyter#635

Open Questions:
  - I am struggling with getting the svg images to build properly.
  - How can this be tested in JupyterLab?

Changes:
  - Alter Notebooks Widget to only display changed cells by using new linked
    list of cells.
  - Add new linked list of cells and lazy version of linked list of cells.
Copy link

@Thompson1985 Thompson1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reveiwed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants