Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Don't double encode item_path for edit button #2588

Closed
wants to merge 1 commit into from
Closed

Don't double encode item_path for edit button #2588

wants to merge 1 commit into from

Conversation

takluyver
Copy link
Member

This is a secondary issue found in #2585.

@takluyver takluyver added this to the 5.1 milestone Jun 20, 2017
@takluyver takluyver mentioned this pull request Jun 20, 2017
Closed
@gnestor
Copy link
Contributor

gnestor commented Jun 20, 2017

This is already implemented in #2449, specifically f43ac2f.

Just needs to be merged...

@takluyver
Copy link
Member Author

Ah, sorry for overlooking that.

@takluyver takluyver closed this Jun 21, 2017
@gnestor
Copy link
Contributor

gnestor commented Jun 21, 2017

👌

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@takluyver @gnestor