-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make notebook 6.5.x point to nbclassic static assets #6474
Conversation
I have installed locally this branch and launching
|
This reverts commit e666731.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Epic PR @ericsnekbytes Tested locally and looks good. Checked the diff. CI failures were also shown before on 6.4.x branch. Will merge. Thx again!
@ericsnekbytes I have reviewed and approved. Can you undraft so I can merge? Thx, |
Ready! |
This makes notebook use the
static
assets ofnbclassic
, so both use the same physical files for future frontend development. Main changes (still being refined) are:__init__
to point to nbclassic/static folderstatic/
folder fromnotebook
nbclassic
will do this itself, we don't need the logic here anymore)Note that this PR involves removing static frontend JS/CSS files from notebook and obtaining those instead from nbclassic, it does not remove the handlers and other logic, those are still in place.