Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make notebook 6.5.x point to nbclassic static assets #6474

Merged
merged 28 commits into from
Jul 25, 2022

Conversation

ericsnekbytes
Copy link
Collaborator

@ericsnekbytes ericsnekbytes commented Jul 14, 2022

This makes notebook use the static assets of nbclassic, so both use the same physical files for future frontend development. Main changes (still being refined) are:

  • Change the DEFAULT_STATIC_FILES_PATH in __init__ to point to nbclassic/static folder
  • Delete the static/ folder from notebook
  • Remove static file build/related logic from setup system (nbclassic will do this itself, we don't need the logic here anymore)
  • Remove JS tests from CI (those tests are covered in nbclassic)

Note that this PR involves removing static frontend JS/CSS files from notebook and obtaining those instead from nbclassic, it does not remove the handlers and other logic, those are still in place.

@ericsnekbytes ericsnekbytes changed the base branch from 6.4.x to 6.5.x July 15, 2022 12:04
@echarles
Copy link
Member

echarles commented Jul 16, 2022

I have installed locally this branch and launching jupyter notebook I receive

  File ".../jupyter-notebook/notebook/__init__.py", line 29, in <module>
    from notebook.nbextensions import install_nbextension
ModuleNotFoundError: No module named 'notebook.nbextensions'

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic PR @ericsnekbytes Tested locally and looks good. Checked the diff. CI failures were also shown before on 6.4.x branch. Will merge. Thx again!

@echarles
Copy link
Member

@ericsnekbytes I have reviewed and approved. Can you undraft so I can merge? Thx,

@ericsnekbytes ericsnekbytes changed the title (DRAFT/WIP) Make notebook 6.5.x point to nbclassic static assets Make notebook 6.5.x point to nbclassic static assets Jul 25, 2022
@ericsnekbytes ericsnekbytes marked this pull request as ready for review July 25, 2022 12:22
@ericsnekbytes
Copy link
Collaborator Author

@ericsnekbytes I have reviewed and approved. Can you undraft so I can merge? Thx,

Ready!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants