Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Using group method to match regex items #6522

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Using group method to match regex items #6522

merged 1 commit into from
Aug 24, 2022

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Aug 23, 2022

Works for Python versions < 3.6. Fixes #6521 so users can install extensions as noted by @GaspardBT

@RRosio
using group method to match regex items, which works for Python versi…
dc0c8c4 
…ons < 3.6. Fix so users can install extensions
@RRosio RRosio added the bug label Aug 23, 2022
@RRosio RRosio marked this pull request as ready for review August 23, 2022 16:45
echarles
echarles approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx @RRosio

@echarles echarles merged commit a8d5ca7 into jupyter:5.7.x Aug 24, 2022
@jtpio jtpio mentioned this pull request Aug 26, 2022
Closed
@RRosio RRosio mentioned this pull request Aug 26, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RRosio @echarles