Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to JupyterLab 4.1 #7096

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Update to JupyterLab 4.1 #7096

merged 4 commits into from
Oct 27, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 9, 2023

Fixes #7083
Fixes #6902

image

@jtpio jtpio added this to the 7.1 milestone Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Binder 👈 Launch a Binder on branch jtpio/notebook/lab-4-1

@jtpio
Copy link
Member Author

jtpio commented Oct 9, 2023

Some CSS breakages:

image

image

Edit: actually looking fine with the latest packages 👍

@@ -44,12 +44,13 @@
"watch:lib": "lerna exec --stream --scope @jupyter-notebook/metapackage jlpm watch"
},
"resolutions": {
"@jupyterlab/rendermime-interfaces": "3.8.3-alpha.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be temporary until jupyterlab/jupyterlab#15240 or similar is fixed upstream.

@jtpio
Copy link
Member Author

jtpio commented Oct 9, 2023

This new dev tools error seems to be related to jupyterlab/jupyterlab#14920:

image

@jtpio
Copy link
Member Author

jtpio commented Oct 27, 2023

bot please update playwright snapshots

@jtpio jtpio closed this Oct 27, 2023
@jtpio jtpio reopened this Oct 27, 2023
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This snapshot was reverted from #7103 because the upstream change is currently only available in 4.0.7, but not in a 4.1 pre-release.

@jtpio jtpio marked this pull request as ready for review October 27, 2023 11:49
@jtpio
Copy link
Member Author

jtpio commented Oct 27, 2023

Getting this one in now that we have a 7.0.x branch: https://github.com/jupyter/notebook/tree/7.0.x

@jtpio jtpio merged commit 53b47af into jupyter:main Oct 27, 2023
@jtpio jtpio deleted the lab-4-1 branch October 27, 2023 12:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to JupyterLab 4.1 Feature Request: Mermaid Support
1 participant