Issue #7231 Update base.css

[v-lozko]

Updating to limit max width of inner windowed panel. Inner panel was extending past screen on right.

Added a max-width to the innerWindowedPanel as it was extending past 1200 px when window was larger than that.

Here is screenshot of notebook in binder

[github-actions]

👈 Launch a Binder on branch v-lozko/notebook/patch-1

[v-lozko]

Sorry, I forgot to add a PR label. As the description states this is related to issue 7231

[jtpio]

Thanks @v-lozko for working on this.

Would you be able to add a screenshot to the top comment so it's easier to have an idea of the fix?

[v-lozko]

Updated the top comment

[jtpio]

Ah the failing UI tests may be relevant, as this change is affecting the default width for notebooks not using the full windowing mode:

[v-lozko]

I realized didn't actually take a screenshot of the actual notebook above. In any case, it seems to work appropriately when resizing it in both full and defer mode. It looks like its just a bit too wide. seems like only 693 pixels differ and some of those are the icons, and the height is 68.6px, so must be only a few pixels off on width. I set it to that variable because it seemed most appropriate.

What should be the next steps forward then to resolve this?

[jtpio]

Thanks @v-lozko. I think we can trigger a snapshot update to fix the UI tests, and the PR should be ready to go.

[jtpio]

bot please update playwright snapshots

[jtpio]

Ah now that JupyterLab 4.2.0b0 is released and defaults to the full mode by default (jupyterlab/jupyterlab#15964), it looks like there is a misalignment of the notebook now.

[jtpio]

FYI @v-lozko I picked up your change in #7312 directly (adding you as co-author of the commit) to facilitate the update to the newer JupyterLab release.

[v-lozko]

Awesome, thanks!