Skip to content

chore: Udpate node, replace add with copy #213

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2019
Merged

chore: Udpate node, replace add with copy #213

merged 1 commit into from
Nov 12, 2019

Conversation

jgwerner
Copy link
Contributor

@jgwerner jgwerner commented Nov 8, 2019

  • Update Node to v12.13
  • Use COPY instead of ADD

@jgwerner
udpate node, replace add with copy
7041173 
Signed-off-by: Greg <werner.greg@gmail.com>
@minrk minrk merged commit 1b9cd1b into jupyterhub:master Nov 12, 2019
@minrk
Copy link
Member

minrk commented Nov 12, 2019

Thanks!

@consideRatio
Copy link
Member

After this merged PR, port 8000 is no longer exposed by default when creating a docker container, is that an issue?

@consideRatio consideRatio mentioned this pull request Nov 12, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgwerner @minrk @consideRatio