Skip to content

JupyterLab4 compatibility draft: Dependency updates and typescript code changes #270

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Nov 1, 2023

Conversation

ericsnekbytes
Copy link
Contributor

@ericsnekbytes ericsnekbytes commented Apr 14, 2023

This PR serves as a starting point for updating the Variable Inspector extension for compatibility with JupyterLab 4. Basic summary:

  • Update extension logic in typescript
  • Bump dependencies on JupyterLab and its core plugins

@ericsnekbytes ericsnekbytes changed the title (DRAFT) JupyterLab4 compatibility draft: Dependency updates and typescript code changes JupyterLab4 compatibility draft: Dependency updates and typescript code changes Apr 14, 2023
@lckr
Copy link
Collaborator

lckr commented Apr 18, 2023

Hey, thanks for this MR! I will try to get the CI here to work again before merging.
Additionally I'm thinking to wait for the official 4.0 release of Jupyterlab before releasing a new version of the extension. But on the other hand the dependencies probably won't change too much and we could already release with a JLab pre-release as target. What are your thoughts on this?

@ericsnekbytes
Copy link
Contributor Author

Hey! Sorry for the delay, I would also recommend waiting for the Lab 4 official release (so both the core lab dependencies and the the dependency on lab itself would need to be modified to support the new released version numbers + any versions in that release series in that case).

@ericsnekbytes
Copy link
Contributor Author

@lckr Just thought I'd mention that JupyterLab 4 is out now, in case you haven't heard already :)

@lckr
Copy link
Collaborator

lckr commented May 28, 2023

Thanks @ericsnekbytes, I'm currently working on the update that will also change a few other things instead of just the dependency. I hope to get it done within the next week.

@lckr
Copy link
Collaborator

lckr commented May 28, 2023

But if you were to update this MR with the current package versions we could also merge it before I finish the other changes :)

@ericsnekbytes
Copy link
Contributor Author

But if you were to update this MR with the current package versions we could also merge it before I finish the other changes :)

@lckr I have updated this PR with new package versions for Lab / the dependencies, hope this helps!

@fcollonval fcollonval merged commit bbcac55 into jupyterlab-contrib:main Nov 1, 2023
@fcollonval fcollonval added the maintenance Maintenance action on the project label Nov 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
maintenance Maintenance action on the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants