Skip to content

Add option to filter out variables #290

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

kentarolim10
Copy link
Contributor

@kentarolim10 kentarolim10 commented Nov 4, 2023

Description

  • Adds new filtered object to keep track of what of variables should be filtered
  • Adds option to filter out certain variable types
  • Adds option to filter out certain variable names
  • Variable names have the ability to filter out using a simple regex
  • https://www.npmjs.com/package/wildcard-match
  • Checks this filtered object every time a row is added to the variable table

Fixes #165


Edited to link the issue with the PR; see the documentation for more information

Copy link

github-actions bot commented Nov 4, 2023

Binder 👈 Launch a Binder on branch kentarolim10/jupyterlab-variableInspector/add-variable-filter

@kentarolim10 kentarolim10 changed the title Check if type is in filter when adding row Add option to filter out variables Nov 15, 2023
@fcollonval fcollonval added the enhancement New feature or request label Nov 16, 2023
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kentarolim10 the code looks great

Would you mind creating a unit test using jest and the testing-library for testing the component feature.

To setup jest test framework, try running copier update . and be sure to answer yes to the question does this extension have tests. It should create the basic setup files. Let me know if you have trouble setting that.

@kentarolim10
Copy link
Contributor Author

Thanks @kentarolim10 the code looks great

Would you mind creating a unit test using jest and the testing-library for testing the component feature.

To setup jest test framework, try running copier update . and be sure to answer yes to the question does this extension have tests. It should create the basic setup files. Let me know if you have trouble setting that.

I have created tests but I think I may of done it wrong. I tried to do copier update . but then the package json ended up breaking. Additionally, the only test files I could find were with playwright and not jest, so that is what I ended up using.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kentarolim10

@fcollonval fcollonval merged commit 1f2c840 into jupyterlab-contrib:main Nov 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Future Request] Hidden uneccessary variables
2 participants