Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to the new extension distribution system #33

Merged
merged 5 commits into from
Jan 26, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 26, 2021

Fixes #32

This was bootstrapped from the TypeScript cookiecutter: https://github.com/jupyterlab/extension-cookiecutter-ts

Then:

  • removed TypeScript files and TypeScript related scripts
  • removed the optional server exension
  • added lib/index.js

Can be tested locally with:

mamba create -n test cookiecutter nodejs python  -y
conda activate test
cookiecutter https://github.com/jtpio/extension-cookiecutter-js --checkout packaging

@jtpio jtpio marked this pull request as ready for review January 26, 2021 15:58
@jtpio jtpio mentioned this pull request Jan 26, 2021
43 tasks
@jtpio
Copy link
Member Author

jtpio commented Jan 26, 2021

Since quite a bit of the boilerplate code now comes from the TypeScript cookiecutter, it would be nice if the JS cookiecutter could somehow "inherit" from the TS cookiecutter (which is more actively maintained), and only keep the JS relevant parts.

@jtpio
Copy link
Member Author

jtpio commented Jan 26, 2021

Alternatively, maybe the TS cookiecutter should actually support JS too? When prompted, the extension author could choose between a JS or TS extension (defaulting to TS):

  • if JS, then the lib folder is created
  • if TS, then the src folder and other TypeScript related files are populated

Which means the https://github.com/jupyterlab/extension-cookiecutter-js repo could simply be archived in favor of https://github.com/jupyterlab/extension-cookiecutter-ts.

@blink1073
Copy link
Contributor

Looks like inheriting cookiecutters is not yet possible: cookiecutter/cookiecutter#1485

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 9992bc9 into jupyterlab:master Jan 26, 2021
@jtpio jtpio deleted the packaging branch January 26, 2021 21:57
@jtpio jtpio mentioned this pull request Jan 26, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt the new extension distribution system
2 participants