Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minor styling updates. #54

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

ellisonbg
Copy link
Contributor

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read and understand the [Code of Conduct][code-of-conduct].
  • Read and understood the [licensing terms][license].
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Submitted against master branch.

Description

Address minor styling issue - see attached screenshot.

Screen Shot 2019-11-02 at 2 59 58 PM

The styling work isn't complete, but this can be merged as is and further improvements done later. My suggestion is the refactor everything to address #53 before further styling work is done as the current CSS is brittle and the styling improvements are really painful to make as there is no way to track from the JS dev console back to the component responsible for the styling.

@kgryte kgryte merged commit 0f91548 into jupyterlab:master Nov 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants