Set aria-label to title if no label for (#16262)

Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
jupyterlab · May 1, 2024 · ca4afa1 · ca4afa1
1 parent 9ac9069
commit ca4afa1
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/ui-components/src/components/toolbar.tsx b/packages/ui-components/src/components/toolbar.tsx
@@ -843,6 +843,9 @@ export function ToolbarButtonComponent(
     }
   };
 
+  const title = getTooltip();
+  const disabled = props.enabled === false;
+
   return (
     <Button
       appearance="stealth"
@@ -851,14 +854,15 @@ export function ToolbarButtonComponent(
           ? props.className + ' jp-ToolbarButtonComponent'
           : 'jp-ToolbarButtonComponent'
       }
+      aria-disabled={disabled}
+      aria-label={props.label || title}
       aria-pressed={props.pressed}
-      aria-disabled={props.enabled === false}
       {...props.dataset}
-      disabled={props.enabled === false}
+      disabled={disabled}
       onClick={handleClick}
       onMouseDown={handleMouseDown}
       onKeyDown={handleKeyDown}
-      title={getTooltip()}
+      title={title}
       minimal
     >
       {(props.icon || props.iconClass) && (