Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Brainf... is listed as syntax highlight option #14373

Closed
fcollonval opened this issue Apr 12, 2023 · 1 comment · Fixed by #14406
Closed

Brainf... is listed as syntax highlight option #14373

fcollonval opened this issue Apr 12, 2023 · 1 comment · Fixed by #14406
Assignees
Labels
Milestone

Comments

@fcollonval
Copy link
Member

Description

Brainf... should not be listed in the text file editor syntax highlight option.

That condition is not working

if (spec.name.indexOf('brainf') === 0) {

this is likely a consequence of

#13639

Reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error '...'

Expected behavior

Context

  • Operating System and version:
  • Browser and version:
  • JupyterLab version:
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output
Paste the output from your browser Javascript console here, if applicable.
@fcollonval fcollonval added bug status:Needs Triage Applied to new issues that need triage labels Apr 12, 2023
@fcollonval fcollonval added this to the 4.0.0 milestone Apr 12, 2023
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Apr 18, 2023
@JasonWeill
Copy link
Contributor

Notably, this language is not in the list accessible in the text editor's status bar button.

We may be able to fix this by removing the menu option in JupyterLab.

image

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants