Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Datagrid: Add a public API to get the current viewport #695

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Datagrid: Add a public API to get the current viewport #695

merged 8 commits into from
Apr 16, 2024

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou added enhancement New feature or request api-change Pull requests introducing an API change labels Apr 11, 2024
krassowski
krassowski reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests would be good to have.

@krassowski
Copy link
Member

Thanks! Two things left here:

@martinRenou martinRenou marked this pull request as draft April 16, 2024 07:03
@martinRenou martinRenou marked this pull request as ready for review April 16, 2024 07:45
@martinRenou martinRenou requested a review from krassowski April 16, 2024 07:45
krassowski
krassowski approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @martinRenou!

@martinRenou @krassowski
Fix typo
ec16627 
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@krassowski krassowski merged commit f85aad4 into jupyterlab:main Apr 16, 2024
17 checks passed
@martinRenou martinRenou deleted the datagrid-viewport branch April 16, 2024 11:04
@fcollonval fcollonval mentioned this pull request Jun 28, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jtpio jtpio jtpio left review comments

@krassowski krassowski krassowski approved these changes

Assignees

@martinRenou martinRenou

Labels
api-change Pull requests introducing an API change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @krassowski @jtpio