This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Update UI Tests to use Galata #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We can also add visual regression tests and reference snapshots to help detect issues like #263, for example when updating to newer |
|
This produces HTML reports:
New reference snapshots are generated on failure. |
|
cc @fcollonval if you want to have a look. Things seems to be working fine also when opening multiple browser tabs. I opened jupyterlab/jupyterlab#11414 to discuss how we can maybe improve the |
fcollonval
approved these changes
Nov 8, 2021
This was referenced Nov 11, 2021
Merged
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with #228.
Update to
@jupyterlab/galatawhich is built on top of@playwright/test, and brings a couple of helper functions we should be able to use in RetroLab too.