Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No JS callback #34

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

SylvainCorlay
Copy link
Member

@jtpio jtpio added the enhancement New feature or request label Mar 9, 2022
@DerThorsten DerThorsten merged commit 17a7593 into jupyterlite:main Mar 9, 2022
@jtpio
Copy link
Member

jtpio commented Mar 9, 2022

Thanks!

I just checked this locally by downloading the built assets from https://github.com/jupyterlite/xeus-lua-kernel/actions/runs/1955794674, and testing in a local environment with:

mamba create -n tmp jupyterlab=3 -y
mamba activate tmp
python -m pip install jupyterlite_xeus_lua-0.2.1-py3-none-any.whl  
python -m pip install jupyterlite --pre
jupyter lite build

Then serving the site with python -m http.server.

Using the game of life example from https://github.com/jupyterlite/demo/blob/main/content/xeus-lua/game-of-life.ipynb seems to be giving the following error:

image

@DerThorsten
Copy link
Collaborator

DerThorsten commented Mar 9, 2022

@jtpio I can reproduce the error and it seems like hbox = ilua.widgets.hbox() is broken. I some investigate more...

@DerThorsten
Copy link
Collaborator

fixed in jupyter-xeus/xeus-lua#25

@SylvainCorlay SylvainCorlay deleted the no-callback branch March 9, 2022 13:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants