-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(user_roles): Add accept invitation API and UserJWTAuth
#3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-users
Area: Users
labels
Jan 17, 2024
racnan
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets give this API the possibility to not send the signin payload as response payload. Maybe query params?
racnan
reviewed
Jan 17, 2024
apoorvdixit88
approved these changes
Jan 19, 2024
racnan
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if need_dashboard_entry_response
needs to be in query param.
harsh-sharma-juspay
approved these changes
Jan 19, 2024
ThisIsMani
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jan 19, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jan 21, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
A-users
Area: Users
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR will add a new API for accepting invitation and also a new JWT auth type which has only
user_id
.Additional Changes
Motivation and Context
To support the Accept Invite flow in the following flow.
How did you test it?
If any of the
merchant_id
status isactive
, then you will be getting the following response.If
need_dashboard_entry_response
isfalse
or not sent, then the response will be 200 OK.Checklist
cargo +nightly fmt --all
cargo clippy