Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(ckh-source): updated ckh analytics source tables #3397

Merged
merged 4 commits into from
Jan 24, 2024
Merged

chore(ckh-source): updated ckh analytics source tables #3397

merged 4 commits into from
Jan 24, 2024

Conversation

ivor11
Copy link
Contributor

@ivor11 ivor11 commented Jan 18, 2024 •
edited by lsampras
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

updated analytics tables of ckh source to new tables

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Segregating tables in ckh for better access control

How did you test it?

  • check the analytics tab in dashboard

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ivor11 ivor11 self-assigned this Jan 18, 2024
@ivor11 ivor11 requested a review from a team as a code owner January 18, 2024 19:40
@ivor11 ivor11 linked an issue Jan 18, 2024 that may be closed by this pull request
Clickhouse - split the ingestion & query tables in separate databases for better access control #3395
Closed
6 tasks
lsampras
lsampras previously approved these changes Jan 22, 2024
View reviewed changes
@lsampras lsampras dismissed stale reviews from ShivanshMathurJuspay and themself via 58d3a23 January 22, 2024 12:39
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 3f343d3 Jan 24, 2024
10 checks passed
@Gnanasundari24 Gnanasundari24 deleted the chore/ckh-source branch January 24, 2024 09:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@harsh-sharma-juspay harsh-sharma-juspay harsh-sharma-juspay approved these changes

@ShivanshMathurJuspay ShivanshMathurJuspay ShivanshMathurJuspay approved these changes

@lsampras lsampras lsampras left review comments

Assignees

@ivor11 ivor11

Labels
A-Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clickhouse - split the ingestion & query tables in separate databases for better access control
5 participants
@ivor11 @lsampras @ShivanshMathurJuspay @harsh-sharma-juspay @Gnanasundari24