Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(core): Include surcharge amount in frm request #3398

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

fix(core): Include surcharge amount in frm request #3398

wants to merge 28 commits into from

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

hrithikesh026 and others added 27 commits December 12, 2023 00:09
@hrithikesh026
feat(core): enable surcharge support for all connectors
2a7c6a8
@hrithikesh026
fix: calculate display_total_surcharge_amount from int
22ca09d
@hrithikesh026
address comments
e4f0c42
@hrithikesh026
remove redundant call to populate_payment_data() and handle surcharge…
54d4287 
… for payment retry
@hrithikesh026
fix: add net_amount field in PaymentResponse
4bcd7f6
@hyperswitch-bot
docs(openapi): re-generate OpenAPI specification
2231313
@hrithikesh026
Merge branch 'main' into surcharge-for-all-connectors
6885131
@hrithikesh026
do amount operation for PaymentsSessionData
82cc438
@hrithikesh026
Merge branch 'main' into surcharge-for-all-connectors
f47cd02
@hrithikesh026
Merge branch 'main' into surcharge-for-all-connectors
04a31f4
@hyperswitch-bot
chore: update Cargo.lock
a907bb5
@hrithikesh026
Merge branch 'main' into surcharge-for-all-connectors
0e3cb3c
@hrithikesh026
Merge branch 'surcharge-for-all-connectors' into introduce-net-amount…
a9ce9fb 
…-in-payment_response
@hrithikesh026
Merge branch 'main' into introduce-net-amount-in-payment_response
c567755
@hrithikesh026
Merge branch 'main' into introduce-net-amount-in-payment_response
5964b05
@hrithikesh026
create net_amount field in payment_attempt
3c386e1
@hrithikesh026
address comments
bb45695
@hrithikesh026
add comments in up.sql file
acb3f23
@hrithikesh026
use net_amount field directly
80f6ad1
@hrithikesh026
do not populate surcharge and tax amount for manually retried payment
f107d6a
@hrithikesh026
address comments
40a4f3b
@hrithikesh026
make net_amount field optional in payment_attempt
395a93b
@hrithikesh026
refactor: refactor amount field in PaymentAttempt data_model
7fa1ac5
@hrithikesh026
Merge branch 'main' into refactor-amount-in-attempt
15f8b83
@hrithikesh026
Merge branch 'main' into refactor-amount-in-attempt
06f0834
@hrithikesh026
resolve merge related issues
f134a69
@hrithikesh026
fix(core): include surcharge_amount in frm request
b5a9ebd
@hrithikesh026 hrithikesh026 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 19, 2024
@hrithikesh026 hrithikesh026 self-assigned this Jan 19, 2024
@hrithikesh026 hrithikesh026 requested review from a team as code owners January 19, 2024 05:57
@hrithikesh026 hrithikesh026 linked an issue Feb 1, 2024 that may be closed by this pull request
[FEATURE] send metadata field in authentication request for nmi, noon and cryptopay #3514
Closed
2 tasks
@hrithikesh026 hrithikesh026 removed a link to an issue Feb 1, 2024
[FEATURE] send metadata field in authentication request for nmi, noon and cryptopay #3514
Closed
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@hrithikesh026 hrithikesh026

Labels
C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hrithikesh026