Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ci(cypress): Update card number for adyen and status for paypal #5192

Merged
merged 3 commits into from
Jul 4, 2024
Merged

ci(cypress): Update card number for adyen and status for paypal #5192

merged 3 commits into from
Jul 4, 2024

Conversation

likhinbopanna
Copy link
Contributor

@likhinbopanna likhinbopanna commented Jul 3, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  1. Update no_three_ds card number for adyen as previously it was 3D-secure-2 card which was resulting in no_three_ds payment to fail
  2. Update the status for PayPal payments: previously, they would go to a 'processing' state, and refunds were not handled. Now, every PayPal payments goes to a 'succeeded' state
    [Note: Refunds are bit flaky due to issues on the connector's end]
  3. Giropay is Deprecated from PayPal and Stripe and hence added the appropriate error message

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Adyen and Paypal test cases were failing

How did you test it?

CYPRESS

  • Previously PayPal
    image (3)

  • Currently PayPal
    image (4)

  • ADYEN

image
  • STRIPE
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@likhinbopanna likhinbopanna added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 3, 2024
@likhinbopanna likhinbopanna self-assigned this Jul 3, 2024
@likhinbopanna likhinbopanna requested review from a team as code owners July 3, 2024 14:40
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 4, 2024
@pixincreate pixincreate enabled auto-merge July 4, 2024 06:58
@pixincreate pixincreate added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 0796bb3 Jul 4, 2024
11 checks passed
@pixincreate pixincreate deleted the update-adyen-card branch July 4, 2024 08:04
pixincreate added a commit that referenced this pull request Jul 5, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into fixtures-un…
802a1d7 
…ify-cypress

* 'main' of github.com:juspay/hyperswitch: (22 commits)
  refactor: Adding millisecond to Kafka timestamp (#5202)
  chore(version): 2024.07.05.0
  fix(user_auth_method): make id option in auth select (#5213)
  Docs: Updated API - ref for payments (#5172)
  feat(core): add merchant order reference id (#5197)
  feat(analytics): Refund status serialization issue for ckh analytics (#5199)
  fix(router): `override setup_future_usage` filed to on_session based on merchant config (#5195)
  feat(cypress): make tests forcefully skippable (#5176)
  feat(core): Added integrity framework for Authorize and Sync flow with connector as Stripe (#5109)
  ci(cypress): Update card number for adyen and status for paypal (#5192)
  refactor(cypress): error handling and add sync refunds in places where missing (#5128)
  feat(analytics): FRM Analytics (#4880)
  chore(version): 2024.07.04.0
  feat(pm_auth): Added balance check for PM auth bank account (#5054)
  refactor(payment_methods): add appropriate missing logs (#5190)
  refactor(migrations): add commands to make file to run migrations for api v2 (#5169)
  chore(version): 2024.07.03.0
  fix(event): Updated the ApiEventMetric (#5126)
  feat(router): add refunds manual-update api (#5094)
  refactor(payment_link): logs payment links logs coverage (#4918)
  ...
Narayanbhat166 pushed a commit that referenced this pull request Jul 8, 2024
@likhinbopanna @Narayanbhat166
ci(cypress): Update card number for adyen and status for paypal (#5192)
c89b0c6
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pixincreate pixincreate pixincreate approved these changes

@Gnanasundari24 Gnanasundari24 Gnanasundari24 approved these changes

Assignees

@likhinbopanna likhinbopanna

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@likhinbopanna @pixincreate @Gnanasundari24