-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(business_profile): introduce domain models for business profile v1 and v2 APIs #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iness profile update
…orithmUpdate` enum variant
…back to source values for fields not updated
SanchithHegde
added
A-framework
Area: Framework
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
M-database-changes
Metadata: This PR involves database schema changes
labels
Jul 31, 2024
hyperswitch-bot
bot
removed
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jul 31, 2024
SanchithHegde
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jul 31, 2024
hyperswitch-bot
bot
removed
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jul 31, 2024
SanchithHegde
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jul 31, 2024
Narayanbhat166
previously approved these changes
Aug 1, 2024
jarnura
requested changes
Aug 1, 2024
hyperswitch-bot
bot
removed
the
M-database-changes
Metadata: This PR involves database schema changes
label
Aug 1, 2024
SanchithHegde
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Aug 1, 2024
hyperswitch-bot
bot
removed
the
M-database-changes
Metadata: This PR involves database schema changes
label
Aug 1, 2024
jarnura
previously approved these changes
Aug 1, 2024
SanchithHegde
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Aug 1, 2024
Narayanbhat166
previously approved these changes
Aug 1, 2024
Aprabhat19
previously approved these changes
Aug 1, 2024
SanchithHegde
dismissed stale reviews from Aprabhat19, Narayanbhat166, and jarnura
via
August 1, 2024 12:23
5c4df08
hyperswitch-bot
bot
removed
the
M-database-changes
Metadata: This PR involves database schema changes
label
Aug 1, 2024
SanchithHegde
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Aug 1, 2024
Aprabhat19
approved these changes
Aug 1, 2024
Narayanbhat166
approved these changes
Aug 1, 2024
jarnura
approved these changes
Aug 1, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Aug 1, 2024
pixincreate
added a commit
that referenced
this pull request
Aug 5, 2024
…ypress-x2 * 'main' of github.com:juspay/hyperswitch: refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488)
pixincreate
added a commit
that referenced
this pull request
Aug 5, 2024
* 'main' of github.com:juspay/hyperswitch: (37 commits) fix(connector): Fixed status mapping for Plaid (#5525) feat(core): accept profile_id in merchant_account, connectors and customers core functions (#5505) refactor(auth): Pass `profile_id` from the auth to core functions (#5520) refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config (#5478) refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488) feat(cypress): add corner cases (#5481) ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
A-framework
Area: Framework
C-feature
Category: Feature request or enhancement
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR includes the following changes:
business_profile
table always include an update of themodified_at
field.BusinessProfileUpdate::RoutingAlgorithmUpdate
for use in routing code and to slightly improve code readability.apply_changeset()
method onBusinessProfileUpdate
to use fields from the source object for fields which are not being updated.BusinessProfileInterface
implementation forMockDb
, so this should not affect production code.diesel_models
andcommon_enums
crates.hyperswitch_domain_models
crate.To reiterate, this PR does not affect any production code, and only adds new code, while moving existing code behind suitable feature flags.
Additional Changes
This PR includes database migrations for and updates schema for business profile v2 APIs, does not affect business profile v1 schema.
Motivation and Context
Enabling / unblocking business profile v2 changes or any other changes dependent on business profile v2 types.
How did you test it?
Ran the following commands and ensured they've passed:
Attaching a screenshot of the same:
In addition, I've done sanity testing using Postman.
Checklist
cargo +nightly fmt --all
cargo clippy