refactor(core): Use hyperswitch_domain_models within the Payments Core instead of api_models #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…juspay/hyperswitch into add-network-token-data-in-domain-models
lsampras
previously approved these changes
Aug 6, 2024
| let mut updated_card = card.clone(); | ||
| let mut is_card_updated = false; | ||
|
|
||
| // The card_holder_name from locker retrieved card is considered if it is a non-empty string or else card_holder_name is picked | ||
| // from payment_method_data.card_token object | ||
| let name_on_card = if let Some(name) = card.card_holder_name.clone() { | ||
| let name_on_card = if let Some(name) = card.nick_name.clone() { | ||
| //todo! |
| @@ -1770,7 +1772,7 @@ pub async fn retrieve_payment_method_with_temporary_token( | |||
| }) | |||
| .or(Some(name)) | |||
| } else { | |||
| card.card_holder_name.clone() | |||
| card.nick_name.clone() //todo! | |||
There was a problem hiding this comment.
can we add details about what has to be done
SamraatBansal
previously approved these changes
Aug 6, 2024
Chethan-rao
requested changes
Aug 6, 2024
| @@ -2028,7 +2030,7 @@ pub async fn make_pm_data<'a, F: Clone, R>( | |||
| } | |||
|
|
|||
| // TODO: Handle case where payment method and token both are present in request properly. | |||
| let (payment_method, pm_id) = match (request, payment_data.token_data.as_ref()) { | |||
There was a problem hiding this comment.
I don't think this clone is required? u can match on reference of request itself
| @@ -2059,7 +2061,7 @@ pub async fn make_pm_data<'a, F: Clone, R>( | |||
|
|
|||
| (Some(_), _) => { | |||
| let (payment_method_data, payment_token) = payment_methods::retrieve_payment_method( | |||
| request, | |||
| &request.map(Into::into), | |||
There was a problem hiding this comment.
You can just pass request if u make this a reference above. No type conversion required as request type is already Option<domain::PaymentMethodData>
| @@ -314,7 +314,7 @@ impl<F: Send + Clone> GetTracker<F, PaymentData<F>, api::PaymentsRequest> for Co | |||
| payment_method_data: request | |||
| .payment_method_data | |||
| .as_ref() | |||
| .and_then(|pmd| pmd.payment_method_data.clone()), | |||
| .and_then(|pmd| pmd.payment_method_data.clone().map(Into::into).clone()), | |||
There was a problem hiding this comment.
Suggested change
| .and_then(|pmd| pmd.payment_method_data.clone().map(Into::into).clone()), | |
| .and_then(|pmd| pmd.payment_method_data.clone().map(Into::into)), |
Clone not required
Comment on lines
1081
to
1083
|
|
||
| // payment_data.payment_attempt.clone(); | ||
|
|
Comment on lines
1136
to
1140
| let business_sub_label = payment_data | ||
| .payment_attempt | ||
| .clone() | ||
| .business_sub_label | ||
| .clone(); |
There was a problem hiding this comment.
Suggested change
| let business_sub_label = payment_data | |
| .payment_attempt | |
| .clone() | |
| .business_sub_label | |
| .clone(); | |
| let business_sub_label = payment_data | |
| .payment_attempt | |
| .business_sub_label | |
| .clone(); |
same here
| .clone() | ||
| .business_sub_label | ||
| .clone(); | ||
| let authentication_type = payment_data.payment_attempt.clone().authentication_type; |
There was a problem hiding this comment.
Suggested change
| let authentication_type = payment_data.payment_attempt.clone().authentication_type; | |
| let authentication_type = payment_data.payment_attempt.authentication_type.clone(); |
same here
Comment on lines
1147
to
1150
| .payment_attempt | ||
| .clone() | ||
| .payment_method_billing_address_id | ||
| .clone(), |
There was a problem hiding this comment.
Suggested change
| .payment_attempt | |
| .clone() | |
| .payment_method_billing_address_id | |
| .clone(), | |
| .payment_attempt | |
| .payment_method_billing_address_id | |
| .clone(), |
same here
Comment on lines
863
to
865
| .clone() | ||
| .and_then(|payment_method_data_request| payment_method_data_request.payment_method_data) | ||
| .async_and_then(|payment_method_data| async { |
There was a problem hiding this comment.
No need to clone entire payment_method_data of request. Instead take request.payment_method_data as reference and clone payment_method_data_request.payment_method_data inside and_then
Comment on lines
13
to
16
| use crate::types::{ | ||
| api::{self}, | ||
| domain::{self}, | ||
| }; |
There was a problem hiding this comment.
Suggested change
| use crate::types::{ | |
| api::{self}, | |
| domain::{self}, | |
| }; | |
| use crate::types::{ | |
| api,domain | |
| }; |
…juspay/hyperswitch into add-network-token-data-in-domain-models
…juspay/hyperswitch into add-network-token-data-in-domain-models
Chethan-rao
previously approved these changes
Aug 7, 2024
Narayanbhat166
previously approved these changes
Aug 7, 2024
prasunna09
dismissed stale reviews from Narayanbhat166 and Chethan-rao
via
dca748d
Narayanbhat166
previously approved these changes
Aug 8, 2024
Chethan-rao
previously approved these changes
Aug 8, 2024
…juspay/hyperswitch into add-network-token-data-in-domain-models
prasunna09
dismissed stale reviews from Chethan-rao and Narayanbhat166
via
1f91849
Chethan-rao
approved these changes
Aug 9, 2024
Narayanbhat166
approved these changes
Aug 9, 2024
lsampras
approved these changes
Aug 9, 2024
SamraatBansal
approved these changes
Aug 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
TestCases:-
Sanity testing for all the payments flows including save card flow and pm_auth flow.
stripe testing -
cybersource -
saved card payment -
Checklist
cargo +nightly fmt --allcargo clippy