Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: bump MSRV to 1.76.0 #5586

Merged
merged 16 commits into from
Aug 12, 2024
Merged

build: bump MSRV to 1.76.0 #5586

merged 16 commits into from
Aug 12, 2024

Conversation

SanchithHegde
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR bumps the Minimum Supported Rust Version (MSRV) from Rust 1.70 to 1.76.

This PR includes the following changes:

  • Bumps MSRV to 1.76.0.
  • Move lint configuration to workspace level [lints] table and removes the .cargo/config.toml file.
  • Updates CI workflows to handle the removal of the .cargo/config.toml file.
  • Removes unnecessary #![forbid(unsafe_code)] annotations in crates.
  • Removes unused main.rs file in the analytics crate.
  • Enables clippy warnings on usages of println!() and eprintln!() with the clippy::print_stdout and the clippy::print_stderr lints, respectively.
  • Removes the unused static_cache module in the common_utils crate.
  • Updates some usages of map_err() which returned the original error with inspect_err().

Motivation and Context

Bumping MSRV allows us to take advantage of the new features introduced and functions / methods stabilized between Rust 1.70 and 1.76. Some of the features / functions include:

In addition, this would also allow us to update some of our dependencies to newer versions.

How did you test it?

N/A

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Aug 10, 2024
@SanchithHegde SanchithHegde self-assigned this Aug 10, 2024
@SanchithHegde SanchithHegde requested review from a team as code owners August 10, 2024 13:47
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 10, 2024
@SanchithHegde SanchithHegde requested a review from a team as a code owner August 10, 2024 14:14
crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved
crates/router/src/core/payment_methods/vault.rs Outdated Show resolved Hide resolved
crates/storage_impl/src/lib.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 12, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 59b36a0 Aug 12, 2024
14 checks passed
@likhinbopanna likhinbopanna deleted the msrv-1.76.0 branch August 12, 2024 10:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-refactor Category: Refactor M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants