-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
build: bump MSRV to 1.76.0 #5586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
C-refactor
Category: Refactor
labels
Aug 10, 2024
SanchithHegde
requested review from
jarnura,
lsampras,
Narayanbhat166,
prajjwalkumar17 and
Chethan-rao
August 10, 2024 13:47
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Aug 10, 2024
… `inspect_err()`
SanchithHegde
force-pushed
the
msrv-1.76.0
branch
from
August 10, 2024 14:08
f80c5f4
to
031df6b
Compare
jarnura
requested changes
Aug 12, 2024
jarnura
approved these changes
Aug 12, 2024
Chethan-rao
approved these changes
Aug 12, 2024
lsampras
approved these changes
Aug 12, 2024
Narayanbhat166
approved these changes
Aug 12, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Aug 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
C-refactor
Category: Refactor
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR bumps the Minimum Supported Rust Version (MSRV) from Rust 1.70 to 1.76.
This PR includes the following changes:
[lints]
table and removes the.cargo/config.toml
file..cargo/config.toml
file.#![forbid(unsafe_code)]
annotations in crates.main.rs
file in theanalytics
crate.println!()
andeprintln!()
with theclippy::print_stdout
and theclippy::print_stderr
lints, respectively.static_cache
module in thecommon_utils
crate.map_err()
which returned the original error withinspect_err()
.Motivation and Context
Bumping MSRV allows us to take advantage of the new features introduced and functions / methods stabilized between Rust 1.70 and 1.76. Some of the features / functions include:
Cargo.toml
: Our previous lint configuration was done via settingRUSTFLAGS
in.cargo/config.toml
, which re-compiles all crates if we introduce a new lint.Result::inspect
,Result::inspect_err
andOption::inspect
.type_name_of_val
In addition, this would also allow us to update some of our dependencies to newer versions.
How did you test it?
N/A
Checklist
cargo +nightly fmt --all
cargo clippy