Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(pm_auth): Fixed deserialize logic in pm_auth core #5615

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

Sarthak1799
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Earlier, the mandate request was inserting another entry in payment_methods table which interfered with pm_auth when running it again. The /auth/exchange call was failing due to this.
Have fixed the logic in pm_auth to be more specific.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Can be tested via SDK

  1. Test Pm auth flow (with "setup_future_usage": "off_session" passed in payment_create and customer_acceptance passed in payment_confirm)
  2. Retest the Pm auth flow

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sarthak1799 Sarthak1799 added the C-bug Category: Bug label Aug 13, 2024
@Sarthak1799 Sarthak1799 self-assigned this Aug 13, 2024
@Sarthak1799 Sarthak1799 requested a review from a team as a code owner August 13, 2024 11:30
@Sarthak1799 Sarthak1799 linked an issue Aug 14, 2024 that may be closed by this pull request
2 tasks
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit f66b09f Aug 14, 2024
14 checks passed
@likhinbopanna likhinbopanna deleted the pm-auth-exchange-fix branch August 14, 2024 13:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix Deserialization error in Pm auth core
4 participants